Support for '@' expressions #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Would you be up for adding something to README mentioning this? Maybe an item on the Features list and a usage example? |
|
@HB9HIL Looks like there are some test failures. |
upps. I forgot to catch the empty case. I also added the necessary tests. Sorry :) |
bradymholt
reviewed
May 6, 2024
| '@monthly': '0 0 1 * *', | ||
| '@weekly': '0 0 * * 0', | ||
| '@daily': '0 0 * * *', | ||
| '@midnight': '0 0 * * *', |
There was a problem hiding this comment.
@midnight - I'm not aware of a cron implementation that supports this. Is there one?
There was a problem hiding this comment.
yep see here: https://www.unix.com/man-page/linux/5/crontab/
|
The changes in PR were just released in v2.50.0 🎉. |
Thanks to you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for '@' expressions.
@Yearly =
0 0 1 1 *@annually =
0 0 1 1 *@monthly =
0 0 1 * *@Weekly =
0 0 * * 0@daily =
0 0 * * *@midnight =
0 0 * * *@hourly =
0 * * * *The @ expressions gots translated in a basic cron and given to the origin parse function. Let me know what you think.