Ordering days on parse() #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test
bradymholt
reviewed
Nov 9, 2023
Comment on lines
+53
to
+55
| if (arrayElement.length === 0) { | ||
| arrayElement.push("*"); | ||
| } |
There was a problem hiding this comment.
To support the following:
it("dayOfWeek specified as comma", function () { assert.equal(new CronParser("*/5 * * * * ,").parse()[5], "*"); });
There was a problem hiding this comment.
Is that a valid syntax for a cron?
There was a problem hiding this comment.
*/5 * * * * , is an invalid syntax, this is why it parsed to */5 * * * * * which is a valid syntax.
anyhow, it was an existing test that I didn't want to break.
My challenge was to add this fix while keeping all the 212 (+1 the one I added) running.
|
Thanks! |
|
The changes in PR were just released in v2.42.0 🎉. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add relevant test under the 'At' section