Merge pull request #49 from rbajaj1997/master

bradtraversy · web-flow · commit 4dd2f9dd57da · 2021-03-08T07:45:04.000-05:00
[Bug Fix] Error on deselecting last cup in project 16
diff --git a/drink-water/script.js b/drink-water/script.js
@@ -11,7 +11,7 @@ smallCups.forEach((cup, idx) => {
 
 function highlightCups(idx) {
     if (idx===7 && smallCups[idx].classList.contains("full")) idx--;
-    if(smallCups[idx].classList.contains('full') && !smallCups[idx].nextElementSibling.classList.contains('full')) {
+    else if(smallCups[idx].classList.contains('full') && !smallCups[idx].nextElementSibling.classList.contains('full')) {
         idx--
     }
 
@@ -46,4 +46,4 @@ function updateBigCup() {
         remained.style.visibility = 'visible'
         listers.innerText = `${2 - (250 * fullCups / 1000)}L`
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ smallCups.forEach((cup, idx) => {`
`11`	`11`
`12`	`12`	`function highlightCups(idx) {`
`13`	`13`	`if (idx===7 && smallCups[idx].classList.contains("full")) idx--;`
`14`		`- if(smallCups[idx].classList.contains('full') && !smallCups[idx].nextElementSibling.classList.contains('full')) {`
	`14`	`+ else if(smallCups[idx].classList.contains('full') && !smallCups[idx].nextElementSibling.classList.contains('full')) {`
`15`	`15`	`idx--`
`16`	`16`	`}`
`17`	`17`
`@@ -46,4 +46,4 @@ function updateBigCup() {`
`46`	`46`	`remained.style.visibility = 'visible'`
`47`	`47`	listers.innerText = `${2 - (250 * fullCups / 1000)}L`
`48`	`48`	`}`
`49`		`-}`
	`49`	`+}`