Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Latest source code pro with Russian / Cyrillic / Greek support. #9861

Open
core-ai-bot opened this issue Aug 30, 2021 · 17 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by abose
Tuesday Jun 23, 2015 at 09:27 GMT
Originally opened as adobe/brackets#11301


Latest source code pro with Russian / Cyrillic / Greek support.
these fonts now support the WGL4 character set.


abose included the following code: https://github.com/adobe/brackets/pull/11301/commits

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Tuesday Jun 23, 2015 at 15:11 GMT


Note: Look over here to see the changes and compare the old and new versions: adobe/brackets@07c3de7 (Screenshots taken on a Windows 8.1, 1366x768 laptop)

The new version looks bolder and appears to be more readable to me.
I like it. :shipit:

@core-ai-bot
Copy link
Member Author

Comment by abose
Wednesday Jun 24, 2015 at 05:34 GMT


+1 I too like the new look .

@core-ai-bot
Copy link
Member Author

Comment by abose
Wednesday Jun 24, 2015 at 14:15 GMT


@rawat11 If There are no significant defects apart from this, Can we go ahead with this integration ?

@core-ai-bot
Copy link
Member Author

Comment by sprintr
Wednesday Jun 24, 2015 at 20:08 GMT


After trying this out with my normal preferences (13px, "SourceCodePro-Medium"), I found that superscript dot of letter i doesn't have much distance from its bottom body and seems to be touching each other.

After:
after

Before:
before

@core-ai-bot
Copy link
Member Author

Comment by nethip
Wednesday Jun 24, 2015 at 20:13 GMT


@sprintr Good observation! We should watch out for these kind of changes which are subtle but might impact the readability of code in general.

@rawat11 Please test specifically on MAC as there seem to be lot of font rendering issues on MAC and I am sure you will find a jewel in there 😄

@core-ai-bot
Copy link
Member Author

Comment by nethip
Wednesday Jun 24, 2015 at 20:15 GMT


@sprintr Another question. Are you seeing this with certain font sizes or are you seeing this in general with all the font sizes?

@core-ai-bot
Copy link
Member Author

Comment by sprintr
Wednesday Jun 24, 2015 at 20:25 GMT


@nethip It happen for (16px, 19px, 21px, 25px, 28px, 42px) etc as well, but seems bearable. with 13px it seems touching.

@core-ai-bot
Copy link
Member Author

Comment by sprintr
Wednesday Jun 24, 2015 at 21:31 GMT


Using my color palette extension, to get a good view of the problem with i.

2015-06-25 02_25_30-c__users_aminullah_desktop_greenshot_after png test - brackets

@core-ai-bot
Copy link
Member Author

Comment by rawat11
Thursday Jun 25, 2015 at 03:56 GMT


@abose Yes, the new font is definitely more readable, our internal team is verifying it, will update once it's done.

@core-ai-bot
Copy link
Member Author

Comment by nethip
Thursday Jun 25, 2015 at 03:57 GMT


@sprintr Thanks for the screenshots.@rawat11 do we want to file a bug at https://github.com/adobe-fonts/source-code-pro

@core-ai-bot
Copy link
Member Author

Comment by rawat11
Thursday Jun 25, 2015 at 04:03 GMT


@nethip On MAC, there is some issue with the font rendering, some of the characters are not clearly visible with the respect to the other characters on the same plane.
Also there visibility is increased once we increase the font size.

1

On increasing the font size

mac

And on windows the same data renders nicely
cyrillic

@core-ai-bot
Copy link
Member Author

Comment by nethip
Thursday Jun 25, 2015 at 04:06 GMT


@rawat11 Thanks! Could you go ahead and update this with the above screenshots and the testing details.

@core-ai-bot
Copy link
Member Author

Comment by rawat11
Thursday Jun 25, 2015 at 04:11 GMT


@nethip We already have a issue raised there, do you want me log another ? I can do that otherwise

@core-ai-bot
Copy link
Member Author

Comment by nethip
Thursday Jun 25, 2015 at 04:33 GMT


@rawat11 That's fine! Let us wait to hear from@pauldhunt on that.

@core-ai-bot
Copy link
Member Author

Comment by abose
Thursday Jun 25, 2015 at 09:20 GMT


Reverted the font to TTF. Though I like the OTF rendering in windows better, Some of the character glyphs doesn't work well in windows[see https://github.com/adobe-fonts/source-code-pro/issues/98 for discussion].

@core-ai-bot
Copy link
Member Author

Comment by rawat11
Tuesday Jun 30, 2015 at 05:03 GMT


@nethip The new fonts looks good to the linguist team. We can go ahead with the fonts

@core-ai-bot
Copy link
Member Author

Comment by abose
Tuesday Jun 30, 2015 at 07:38 GMT


Thanks@rawat11 For the detailed tests. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant