[CLOSED] Enable SVG Code Hints

[core-ai-bot]

Issue by redmunds
Wednesday Nov 19, 2014 at 17:48 GMT
Originally opened as adobe/brackets#9969

---

This pull request is Step 1 of this plan for improved SVG support:

1. Split SVG into own language (i.e. This PR)
2. Update Brackets SVG Code Hints extension because it's no longer required create an SVG language. Also update documentation because it's no longer necessary to manually switch to SVG language
3. Bonus: Merge SVG Code Hints into Brackets Core (after code cleanup, adding some unit tests, and code review).

There are some other SVG extensions in Brackets Registry that may also benefit from this change.

---

redmunds included the following code: https://github.com/adobe/brackets/pull/9969/commits

[core-ai-bot]

Comment by sprintr
Thursday Nov 20, 2014 at 15:28 GMT

---

I'll update the extension once this gets merged into master.

[core-ai-bot]

Comment by redmunds
Saturday Nov 22, 2014 at 17:38 GMT

---

@sprintr Cool! Note that I updated this pull request so it's no longer dependent on updating CodeMirror, so you can update your code and test it against this branch.

[core-ai-bot]

Comment by peterflynn
Friday Dec 05, 2014 at 19:23 GMT

---

The downside of course is that this will disable any generic XML functionality provided by extensions that are looking at the language. That could potentially affect things like code folding, validation/linting extensions, etc. (But it's easy to fix any extensions with that problem if they're actively being maintained).

[core-ai-bot]

Comment by redmunds
Friday Dec 05, 2014 at 21:54 GMT

---

I tested the Code Folding extension and it still works in SVG files, so it must be using mode instead of language.

[core-ai-bot]

Comment by redmunds
Friday Dec 05, 2014 at 22:42 GMT

---

@peterflynn Change pushed. Note that I merged in latest master so be sure to git submodule update

[core-ai-bot]

Comment by redmunds
Friday Dec 12, 2014 at 00:12 GMT

---

@sprintr I need to get the team to agree, but what do you think about merging your SVG Code Hints extension into Brackets core? I think it fits right in with Brackets target of web technologies.

[core-ai-bot]

Comment by redmunds
Friday Dec 12, 2014 at 01:27 GMT

---

@JeffryBooher I looked through the extensions in the Brackets Registry. The only other extension that looks like it might be affected in brackets-svg-font by@nicolo-ribaudo , but it looks like it correctly checks that SVG Language does not exist before it creates one. So I think it won't be broken, but the code could be cleaned up after this pull request is merged.

[core-ai-bot]

Comment by sprintr
Friday Dec 12, 2014 at 10:33 GMT

---

@redmunds I am fine with merging my extension, but before I submit a PR for that I will have to fix some bugs in it and also write unit tests.

[core-ai-bot]

Comment by redmunds
Friday Dec 12, 2014 at 18:28 GMT

---

@sprintr

I am fine with merging my extension, but before I submit a PR for that I will have to fix some bugs in it and also write unit tests.

Awesome! Yes, we'd need some unit tests. Code also needs to pass JSLint.

[core-ai-bot]

Comment by redmunds
Friday Dec 12, 2014 at 19:12 GMT

---

@sprintr This change has been merged for Brackets 1.1 so you should update your extension for that release. If you submit pull request soon with your extension in core we should be able to get it in 1.2. Let me know if you have any questions.