[CLOSED] Fixed bug with PromiseQueue instances sharing same queue.

[core-ai-bot]

Issue by jayther
Friday Apr 11, 2014 at 09:55 GMT
Originally opened as adobe/brackets#7485

---

Fixed issue with Async.PromiseQueue instances sharing the same queue in the prototype.
Fix is to define _queue and _curPromise in the constructor.
Added to Async-test to test for this case.

(From issue #7484 )

---

jayther included the following code: https://github.com/adobe/brackets/pull/7485/commits

[core-ai-bot]

Comment by njx
Friday Apr 11, 2014 at 17:21 GMT

---

D'oh! Will review.

[core-ai-bot]

Comment by njx
Friday Apr 11, 2014 at 18:04 GMT

---

Reviewed - just a couple of small nits. I also looked through the rest of the codebase and found a couple of other places where I'd made the same mistake - see #7489.

[core-ai-bot]

Comment by jayther
Saturday Apr 12, 2014 at 06:22 GMT

---

Applied the nits, should be good.

[core-ai-bot]

Comment by njx
Tuesday Apr 15, 2014 at 00:15 GMT

---

Thanks, merging.