[CLOSED] Check for extensions updates #6614
Comments
|
Thanks |
|
Yes, we can remove the number completely. I think |
|
We can just use span like what |
|
It'll look like this: |
|
|
|
I have now realized that update check is done every time someone closes and opens the Brackets... Not only my new update check for extension but also the old check for new Sprint version... this is probably spamming the server? Ping |
|
I accidentally hit close! Hopefully this can be merged pretty quickly. |
|
Probably not so fast, I see these lines in master https://github.com/adobe/brackets/blob/master/src/brackets.js#L295-L305 as problematic. I don't think it's a good idea to do requests everytime Brackets are started - I do that quite a lot. |
|
Also Travis says |
|
Hmm I think I saw an email about that from |
|
The Brackets updates and the Registry live on different servers and while the Brackets update request might be short, the registry might be a lot longer. So it should use a lot less bandwidth to call the brackets update than the registry. So it might make sense that one resets on every launch but the other one doesn't. |
|
It might also be nice to add a new API to the registry to retrieve the data for a list of extensions, so that we don't need to get every single extension when only have a few installed. But that might be for another PR. |
|
Ah, it actually does check for the 24 hours, but much more deeper in the code, I'll try to rewrite it a bit. |
|
This works better now - check at most once a day + if extension is uninstalled or updated, do not show notification for it. |
|
There's a bug in our CLA check script where all checks are failing. We're working on it. |
|
Just my two cents on this, I always liked the design where the block turns completely green. This is a screenshot from issue #6723 as a comparison: |
|
Only changing the color is easy to miss for people who are partially colorblind (like me), so I like the idea of also adding a "+" to the icon. |
|
|
|
I agree with |
|
Can we just use what we discussed at adobe/brackets#6723? There's a lot of good points there. |
|
|
|
|
|
Thanks 👍 |
|
Looks great now :) |
|
|
|
|
|
|
|
Ok. There was a discussion about stop showing updates when you opened the extensions manager and decided not to update the extensions. If we don't do that, we could update the icon after the extension manager is open, if it was gray, but there are new extensions. One other thing, it might be nice to not show those extensions that can't be update because thy require a newer version of brackets. |
|
|
|
It's not, I just didn't see much point in calling them in different times. |
Tuesday Mar 25, 2014 at 22:10 GMT
Originally opened as adobe/brackets#7330
As mentioned here adobe/brackets#6723
Ping
@lkcampbell@larz0P.S.: this is not a complete thing but I wanted to get it moving at least a bit (and design is ugly because I don't have a software to work with SVG :)) Feel free to push into this branch.
zaggino included the following code: https://github.com/adobe/brackets/pull/7330/commits
The text was updated successfully, but these errors were encountered: