Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Resizer module should provide better information for error condition #5696

Open
core-ai-bot opened this issue Aug 30, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by redmunds
Monday Dec 16, 2013 at 22:11 GMT
Originally opened as adobe/brackets#6252


As described in this Brackets-Dev discussion thread, the message "Preference key 'undefined' must be a string" is not very helpful.

The problem is that Resizer expects an id on panel, so a simple fix would be for Resizer to verify panel has an id and otherwise display a message in console.

Note that this condition will most likely only affect Extension Authors while developing a new panel, so a console message should be sufficient feedback.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Dec 16, 2013 at 22:25 GMT


I have a fix locally

@core-ai-bot
Copy link
Member Author

Comment by TVScoundrel
Tuesday Feb 11, 2014 at 07:07 GMT


@peterflynn Will you implement the fix or is this still open for beginners like myself?

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Mar 20, 2014 at 18:47 GMT


I've added a warning for this to PR #7264, along with improved docs indicating that an id is actually required

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Apr 23, 2014 at 00:28 GMT


Oops, FBNC@redmunds -- the PR landed last sprint.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Wednesday Apr 23, 2014 at 00:34 GMT


Confirmed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant