Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Fix bug #4593 (Text wrap in context menus & HTML main menus) #5116

Open
core-ai-bot opened this issue Aug 30, 2021 · 5 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by peterflynn
Saturday Oct 19, 2013 at 00:53 GMT
Originally opened as adobe/brackets#5580


See my comments in #4593 for all the gory details...

This fix preserves the current layout, where label & shortcut are not strictly separated columns -- notice how the two columns interlock like puzzle pieces in the working set context menu, for example. But the downside is that this solution may not work in other browsers.

So eventually we may want a more cross-browser fix... but in the meantime this will be a real improvement for the Linux build (which has no native menubar yet).


peterflynn included the following code: https://github.com/adobe/brackets/pull/5580/commits

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Saturday Oct 19, 2013 at 00:54 GMT


See screenshot in #5411 for an example of how nasty the menus are on Linux right now.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Oct 22, 2013 at 23:45 GMT


Soooooo much better! Thanks@peterflynn. Merging!

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Oct 23, 2013 at 23:31 GMT


FBNC@peterflynn

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Wednesday Oct 23, 2013 at 23:31 GMT


Actually,@peterflynn I'm just going to close it since you opened it and fixed it.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Oct 23, 2013 at 23:43 GMT


I assume you meant the bug itself, not the PR? But yeah, I'm fine with closing -- will go ahead & do that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant