[CLOSED] Live Dev is Broken

[core-ai-bot]

Issue by redmunds
Friday Sep 27, 2013 at 19:07 GMT
Originally opened as adobe/brackets#5365

---

1. Select a file with .html file extension
2. Start Live Preview

Results
Error "Open an HTML file in order to launch live preview"

git bisect points to this commit: adobe/brackets@68a5189

In this pull request: adobe/brackets#5224

cc:@peterflynn@JeffryBooher

[core-ai-bot]

Comment by peterflynn
Friday Sep 27, 2013 at 19:20 GMT

---

Crud, looks like we missed a subtle diff between the two APIs that were merged -- one includes the leading "." and the other doesn't. Excluding the "." seems more correct but that means changing a public API. Do we have any sense of how many callers it has?

[core-ai-bot]

Comment by peterflynn
Friday Sep 27, 2013 at 19:23 GMT

---

I only see one call each in JSUtils and FileIndexManager, but the other question is how many extensions might be using it...

[core-ai-bot]

Comment by peterflynn
Friday Sep 27, 2013 at 19:27 GMT

---

The other option is to keep the weird "."-prefixed public API bug with a deprecation warning, and put up a new one with the cleaner semantic before ripping out the old one next sprint. I'm not exactly in love with the current API name anyway :-)

[core-ai-bot]

Comment by njx
Friday Sep 27, 2013 at 19:32 GMT

---

I did a grep in all the existing extensions using@dangoor's handy-dandy Brackets Extension Grabber and found four instances in three extensions out of about a hundred. (A couple of extensions didn't download for some reason.)

I highly recommend BracketsExtensionGrabber, btw. (Note that it's missing one of the deps in the package.json currently--I put up a pull request to fix that.)

[core-ai-bot]

Comment by njx
Friday Sep 27, 2013 at 19:32 GMT

---

BTW, the extensions were angularui.angularjs, brackets-code-folding, and pflynn.svg.preview.

[core-ai-bot]

Comment by JeffryBooher
Friday Sep 27, 2013 at 23:22 GMT

---

FBNC@redmunds

[core-ai-bot]

Comment by redmunds
Saturday Sep 28, 2013 at 00:16 GMT

---

Confirmed. Closing.

[core-ai-bot]

Comment by peterflynn
Saturday Sep 28, 2013 at 00:26 GMT

---

I updated the release notes & filed #5368 for permanently removing the old deprecated API. Will file bugs on the extensions shortly.