[CLOSED] Applied Typographic Tweaks

[core-ai-bot]

Issue by larz0
Saturday Aug 24, 2013 at 17:51 GMT
Originally opened as adobe/brackets#4930

---

This is related to #4912.

---

larz0 included the following code: https://github.com/adobe/brackets/pull/4930/commits

[core-ai-bot]

Comment by larz0
Saturday Aug 24, 2013 at 17:54 GMT

---

@peterflynn could you take a look? (CC'ing@njx as well)

[core-ai-bot]

Comment by peterflynn
Tuesday Aug 27, 2013 at 18:29 GMT

---

@larz0 The font weight changes are interesting, because they essentially encompass the Windows font "faintness" fix from #4955. But in bumping up the font-weight to normal on Mac too, we'll see a disconnect again where the font looks heavier on Mac and lighter on Win. (We won't have the readability issues on Win, though -- that only seems to occur with the lightest weight).

I'm also curious about the antialiasing change at the end of the diff. Is that a trick to tweak the apparent font-weight further? Does it work the same on Retina Mac, non-Retina Mac, and Win?

[core-ai-bot]

Comment by larz0
Wednesday Aug 28, 2013 at 22:52 GMT

---

@peterflynn As discussed. I used "-webkit-font-smoothing: antialiased" to make sure that "font-weight: normal" looks somewhere between light and normal, as opposed to the default look of normal which uses subpixel-antialiased instead (slightly fuzzier).

[core-ai-bot]

Comment by peterflynn
Friday Sep 06, 2013 at 18:30 GMT

---

@larz0 Is this still needed after #4955? If so, looks like it needs a merge to reconcile it with those changes...

[core-ai-bot]

Comment by larz0
Friday Sep 06, 2013 at 21:39 GMT

---

@peterflynn yes this is still need for better legibility. I've cleaned up the code so it should be good to merge.

[core-ai-bot]

Comment by njx
Tuesday Sep 24, 2013 at 17:54 GMT

---

Ping - this would be good to merge soon.

[core-ai-bot]

Comment by peterflynn
Saturday Sep 28, 2013 at 00:21 GMT

---

I've merged this up with master so it's easier to test

[core-ai-bot]

Comment by peterflynn
Saturday Sep 28, 2013 at 00:38 GMT

---

@larz0 Couple things I'm noticing...

1. The bolder highlighting of filenames inside dialogs is gone on Mac, though still present on Win:
   
   

2. The "X" icon in dialogs is now vertically off center
   (see same screenshots above)

3. Text inside textfields now looks quite heavy:
   
   (this screenshot is on Win but it looks very similar to me on Mac)
   vs. current appearance:
   

[core-ai-bot]

Comment by larz0
Sunday Sep 29, 2013 at 23:27 GMT

---

@peterflynn I've fixed the things you mentioned. Made the input less heavier but made the text color black.

[core-ai-bot]

Comment by peterflynn
Tuesday Oct 01, 2013 at 20:50 GMT

---

@larz0 Looks good! I added one commit to this PR to remove the #4568 workaround that is now obsoleted by your broader font-weight changes. I'll go ahead & merge now, but feel free to take a look at the diff on that last commit if you'd like to double-check it.

[core-ai-bot]

Comment by larz0
Tuesday Oct 01, 2013 at 20:55 GMT

---

Thanks@peterflynn sounds good.