Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Use one window for all specs in the suite on more integration tests #4286

Open
core-ai-bot opened this issue Aug 29, 2021 · 3 comments
Open

[CLOSED] Use one window for all specs in the suite on more integration tests #4286

core-ai-bot opened this issue Aug 29, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by TomMalbran
Friday Aug 02, 2013 at 03:50 GMT
Originally opened as adobe/brackets#4635

I just integrated the specs on the following tests into a single window:

  • CSSUtils-test
  • ExtensionUtils-test
  • Menu-test
  • ProjectManager-test
  • WorkingSetView-test

@jasonsanjose Want to review these too? Most were pretty simple to join and all tests are passing fast!!

Is so much nicer to run all integration tests now :)

TomMalbran included the following code: https://github.com/adobe/brackets/pull/4635/commits
@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Aug 02, 2013 at 16:58 GMT

Reviewing

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Aug 02, 2013 at 18:02 GMT

Merging. My note about cleaning up promise handling can really apply to most of our unit tests that were created before waitsForDone. I'll file a code cleanup task.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Aug 02, 2013 at 18:05 GMT

Filed #4638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot