[CLOSED] [OPEN] Fix #4332 and #4409: Sort issues fixed on the Working Set and Project Tree

[core-ai-bot]

Issue by TomMalbran
Monday Jul 15, 2013 at 22:18 GMT
Originally opened as adobe/brackets#4463

---

Fixes for #4332 and #4409.

On #4409 the issue was that the sort wasn't using the locale string functions that JavaScript Implements on the Project Tree, while I did use them on the Working Set Sort.

On #4409 the problem is that windows sort the files without the file extension, and in brackets we were sorting with the file extension. So now in windows it compares only the file names without the extension.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/4463/commits

[core-ai-bot]

Comment by TomMalbran
Wednesday Jul 17, 2013 at 02:14 GMT

---

@RaymondLim Merged with master and renamed the File utils function.

[core-ai-bot]

Comment by RaymondLim
Wednesday Jul 17, 2013 at 06:02 GMT

---

@TomMalbran

You have 3 places that require file name sorting. So I suggest that we should have it as a general filename sort function in FileUtils.js file and call it from these three places.

[core-ai-bot]

Comment by TomMalbran
Wednesday Jul 17, 2013 at 06:12 GMT

---

@RaymondLim All 3 sort methods are different. There are some similarities between them, but which one are you referring to?

[core-ai-bot]

Comment by TomMalbran
Wednesday Jul 17, 2013 at 08:47 GMT

---

@RaymondLim Fixed pushed.

[core-ai-bot]

Comment by TomMalbran
Wednesday Jul 17, 2013 at 23:33 GMT

---

@RaymondLim Fixed pushed. The filenames compare function now handles comparing names and then extensions or extensions and then names.

[core-ai-bot]

Comment by RaymondLim
Thursday Jul 18, 2013 at 02:33 GMT

---

Done with re-review. Just one more comment that I should have caught in earlier reviews.

[core-ai-bot]

Comment by TomMalbran
Thursday Jul 18, 2013 at 02:46 GMT

---

@RaymondLim Fix done, plus a JSDoc that wasn't completely updated.

[core-ai-bot]

Comment by RaymondLim
Thursday Jul 18, 2013 at 03:01 GMT

---

Looks good, thanks. Merging.