[CLOSED] Delay before hover preview

[core-ai-bot]

Issue by peterflynn
Sunday Apr 21, 2013 at 22:43 GMT
Originally opened as adobe/brackets#3531

---

• Changes providers so they're not responsible for showing popover. They return an object with the info needed to show one later.
• Add a popoverState object that can represent both visible and pending (waiting on timer) popovers. If mouse movement invalidates the popoverState, it is canceled -- hidden if visible, timer stopped if pending.
• Unrelated minor fix: ignore mousemove while dragging.
• mousemove processing is now slightly more efficient: we don't reprocess the same line:ch pos repeatedly, and if a popover is already pending/open we don't do any more processing until the mouse leaves that popover's range of text.

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/3531/commits

[core-ai-bot]

Comment by peterflynn
Monday Apr 22, 2013 at 20:43 GMT

---

Merged with Raymond's unit tests. However, Raymond just merged some changes from Randy that require a second merge. Stand by...

[core-ai-bot]

Comment by peterflynn
Monday Apr 22, 2013 at 21:32 GMT

---

@gruehle finally all merged up & ready for review

[core-ai-bot]

Comment by gruehle
Monday Apr 22, 2013 at 22:55 GMT

---

Initial review complete.

[core-ai-bot]

Comment by peterflynn
Tuesday Apr 23, 2013 at 19:06 GMT

---

@gruehle Pushed up responses to code review (including@TomMalbran's code-consolidation suggestion).

I didn't do the spinner part yet since that seemed a little trickier and it sounded like we might want to land the rest of this sooner.

[core-ai-bot]

Comment by gruehle
Tuesday Apr 23, 2013 at 19:07 GMT

---

Looks good. Merging.