Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Code editor font makes me cry (with Russian / Cyrillic text) #3253

Open
core-ai-bot opened this issue Aug 29, 2021 · 28 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by ixth
Wednesday Apr 17, 2013 at 08:54 GMT
Originally opened as adobe/brackets#3465


Workaround: How to switch to a different code font


I have no 'SourceCodePro' and Russian text looks awfully in "MS ゴシック" and "MS Gothic" (which is default according to developer tools). Is there way to set custom font in editor view?

sprint 23 experimental build 0.23.0-6726 (master 6908b48b7), Windows7

2013-04-17_1227

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Apr 17, 2013 at 18:44 GMT


@ainop SourceCodePro is loaded from disk by Brackets using @font-face, so you do have it :-)

However, it looks like SourceCodePro doesn't support Cyrillic characters yet: adobe-fonts/source-code-pro#48. Feel free to comment on that issue so the font team knows you're interested!

In the meantime... there's no way in the Brackets UI to customize fonts yet. But if you're comfortable hacking the code a bit, you can edit www/styles/brackets_theme_default.less and change the .code-font rule. (There's no need to recompile or anything -- just re-launch Brackets). On Windows, Consolas would be a pretty good alternative font to try -- it's what Visual Studio uses, and Brackets used to use it before SourceCodePro went open-source.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Apr 17, 2013 at 18:45 GMT


Adding 'tracking' tag since adobe-fonts/source-code-pro#48 covers the root issue. Clarifying issue title.

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Apr 17, 2013 at 20:59 GMT


Should we consider adding Consolas as a fallback? If the Cyrillic glyphs aren't actually in Source Code Pro, maybe that would just work.

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Apr 17, 2013 at 20:59 GMT


Also,@ainop, we're very sorry we made you cry!

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Apr 17, 2013 at 21:04 GMT


We'd have to be careful about what order Consolas vs. the Asian-language fonts go in since we still want fallback to work there too... but it might be doable. (And of course we'd need to pick an equivalent new fallback option for Mac... was it Lucida Console that we used to use?).

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Apr 17, 2013 at 21:12 GMT


It looks like our Mac font fallback was Menlo, Monaco, monospace. (I think Monaco was in there for older versions of OS X that didn't have Menlo.)

@core-ai-bot
Copy link
Member Author

Comment by ixth
Thursday Apr 18, 2013 at 07:51 GMT


Thanks a lot, guys! I'll patch my setup.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Apr 22, 2013 at 18:21 GMT


Reviewed. Medium priority to me. Might nominate it next sprint.

@core-ai-bot
Copy link
Member Author

Comment by romanov
Tuesday Jul 16, 2013 at 21:09 GMT


Waiting for a great font.

@core-ai-bot
Copy link
Member Author

Comment by HamsterCoder
Tuesday Aug 13, 2013 at 12:10 GMT


Oh, my issue! =)
Russian characters are too far apart from eac other, so the whole code is not monospace anymore. I'll be waiting for a fix too.

@core-ai-bot
Copy link
Member Author

Comment by romanov
Monday Aug 19, 2013 at 08:26 GMT


Current solution: https://github.com/adobe/brackets/wiki/Customize-Your-Code-Font
My recommendation for Windows users is font-family:Consolas, monospace;

untitled-1

@core-ai-bot
Copy link
Member Author

Comment by dananichev
Thursday Aug 29, 2013 at 17:45 GMT


How about selecting the font based on user's language? Atleast as default fonts for user.
My suggestion is
PT Sans
http://www.google.com/fonts/specimen/PT+Sans

@core-ai-bot
Copy link
Member Author

Comment by progreccor
Tuesday Dec 24, 2013 at 10:42 GMT


after installing new sprint i don't know where I can change russian font now?

@core-ai-bot
Copy link
Member Author

Comment by websanya
Thursday Dec 26, 2013 at 16:15 GMT


@progreccor there is a great extension out there: https://github.com/tirithen/brackets-fonts, it provides a simple UI for changing fonts! ☕ PT Mono is pretty sweet.

btw, there is russian community for Brackets: http://vk.com/bracketsio

@core-ai-bot
Copy link
Member Author

Comment by romanov
Monday Jan 20, 2014 at 12:47 GMT


@progreccor adobe/brackets#3465 (comment) (updated)

@luzlol this extension does not support cyrillic (missing &subset=latin,cyrillic).

Source: https://github.com/adobe/brackets/wiki/Customize-Your-Code-Font

@core-ai-bot
Copy link
Member Author

Comment by websanya
Monday Jan 20, 2014 at 13:30 GMT


@romanov in fact it does, I've recorded a screencast for you =) http://www.youtube.com/watch?v=AOuBDLvoDgU

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Apr 21, 2014 at 21:57 GMT


Update: it looks like Cyrillic and Greek support are underway for both Source Code Pro and Source Sans Pro. Here are the relevant issues: adobe-fonts/source-code-pro#48, adobe-fonts/source-sans#6. It looks like Source Sans Pro is done and will be shipping in the next update; not sure about Source Code Pro, but as of a month ago it looks like it was on its way as well.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Apr 21, 2014 at 21:59 GMT


(To clarify: Source Sans Pro is what we use in our UI; Source Code Pro is our editor font.)

@core-ai-bot
Copy link
Member Author

Comment by miguelsousa
Wednesday Jun 18, 2014 at 18:07 GMT


@njx
Cyrillic and Greek support in Source Sans Pro is imminent.
At this point it's not clear when Source Code Pro will ship with the same level of language support.

@core-ai-bot
Copy link
Member Author

Comment by baursak
Wednesday Jul 09, 2014 at 12:48 GMT


"Navigate to .CodeMirror and change font-family to any font with normal cyrillic support"
There are "110 matches" of ".CodeMirror" in file "[brackets folder]/www/styles/brackets.min.css"
Where do I have to "change font-family to any font with normal cyrillic support" ???

@core-ai-bot
Copy link
Member Author

Comment by romanov
Wednesday Jul 09, 2014 at 15:38 GMT


@baursak 4th match:

.CodeMirror {
color:#535353;
font-size:12px;
line-height:1.25;
font-family:"SourceCodePro-Medium","MS ゴシック","MS Gothic",monospace
}

@core-ai-bot
Copy link
Member Author

Comment by baursak
Wednesday Jul 09, 2014 at 17:43 GMT


Thanks. - Will keep it for 0.42 :) - In the meantime I have substituted all the "SourceCodePro" related phrases to "Consolas,monospace" (7 times in total). - It still works OK with Russian. - Great editor!

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Wednesday Jul 09, 2014 at 20:10 GMT


@baursak@romanov Modifying your source code locally is fragile, and you'll have to redo it every time you upgrade Brackets. The workaround listed at the top of this page is much preferred: https://github.com/adobe/brackets/wiki/Customize-Your-Code-Font. (I'll edit the description to make it easier to spot).

@romanov Do you mind if I edit your post above to reduce the font size so it's not as prominent? We probably don't want to encourage people to use that approach too much.

Also note: in the very near future (release 0.42 or 0.43), you should be able to change your code editor font as a setting directly within the Brackets UI, without any hacks needed.

@core-ai-bot
Copy link
Member Author

Comment by baursak
Thursday Jul 10, 2014 at 04:47 GMT


Thank you! - Extension works.
OffTop. - Waiting for replies to:
adobe/brackets#7638
adobe/brackets#7497

@core-ai-bot
Copy link
Member Author

Comment by romanov
Thursday Jul 10, 2014 at 07:28 GMT


@peterflynn edited. Good news about the settings! Yes, the extension is better solution for now.

@core-ai-bot
Copy link
Member Author

Comment by abose
Tuesday Jun 23, 2015 at 09:29 GMT


#11301 With latest source code pro addresses this issue.

@core-ai-bot
Copy link
Member Author

Comment by rawat11
Tuesday Jun 30, 2015 at 05:33 GMT


@abose The latest ttf fonts displays the characters nicely.

Updating the SS for both MAC and WIn

1-russian-win
2-russian-win
5-russian-mac
6-russian-mac

@core-ai-bot
Copy link
Member Author

Comment by abose
Tuesday Jun 30, 2015 at 07:42 GMT


Updated source code pro has support for Russian / Cyrillic text. Closing.
If certain glyphs are not rendered properly, raise another issue stating the details. Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant