[CLOSED] Fix some indent problems

[core-ai-bot]

Issue by gruehle
Monday Feb 13, 2012 at 19:58 GMT
Originally opened as adobe/brackets#250

---

@njx

• Pressing the TAB key on an empty line no longer inserts an additional tab.
• Fixed problem that occasionally added an additional space character when typing a tab.
• Disable built-in "electric chars" feature and replace with a less heavy-handed version. The new version does the following:
  • Only runs when closing braces are typed: "]", "}", or ")"
  • Only runs if the line is all whitespace (except the closing brace)
    This should eliminate the majority of the odd and unpredictable auto-indent behaviors.

This fixes issues #155 and #193.

---

gruehle included the following code: https://github.com/adobe/brackets/pull/250/commits

[core-ai-bot]

Comment by njx
Tuesday Feb 14, 2012 at 00:12 GMT

---

Done with first review.

[core-ai-bot]

Comment by njx
Tuesday Feb 14, 2012 at 02:13 GMT

---

Just tested this and it isn't working for me. If I'm in a blank JS file and I type:

function foo() {
    blah();

then hit Return after blah(); and type the close-brace, it indents it to the right instead of pulling it back over to the left.

[core-ai-bot]

Comment by njx
Tuesday Feb 14, 2012 at 02:15 GMT

---

It looks like the problem is the "smart" argument--if I remove it, it does the right thing. So it must not be the case that passing "smart" is the same as passing nothing.

[core-ai-bot]

Comment by gruehle
Tuesday Feb 14, 2012 at 17:39 GMT

---

Passing 'smart' wasn't so smart after all... removed.