Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] url hinting support #1702

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments
Open

[CLOSED] url hinting support #1702

core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by redmunds
Tuesday Oct 02, 2012 at 18:21 GMT
Originally opened as adobe/brackets#1747


Added a new code hinting type of "url".

Retrieving directory info is asynchronous, so had to cache results and re-initiate code hints. Also use cached info as long as query is in same folder, so very performant.

Current support:

  • page relative urls
  • filter on input
  • "../" path support
  • use Tab key for "select and continue hinting"
  • fix sorting for Windows (i.e. folders first, then files)

Not yet supported (https://trello.com/c/nZx8Z3Ti):

  • filter by desired file type based on tag, type attr, etc.
    • e.g. only show .css, .less, etc. files for
  • add list item to popup modal File Finder dialog
  • make code hints window wider
  • site-root relative urls

redmunds included the following code: https://github.com/adobe/brackets/pull/1747/commits

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday Oct 04, 2012 at 16:44 GMT


Reviewing....

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Thursday Oct 04, 2012 at 19:00 GMT


Done initial review.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Friday Oct 05, 2012 at 18:37 GMT


Changes for code review pushed.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Friday Oct 05, 2012 at 21:53 GMT


Done reviewing new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant