[CLOSED] Couzteau issue1241 #1548
Description
Friday Sep 07, 2012 at 16:40 GMT
Originally opened as adobe/brackets#1583
Hello Brackets people,
Happy to make a stab at my first contribution. :)
All keycode references in src should be updated. All tests are passing.
I have not updated all tests to use the new module yet, but would be happy to update them soon.
Got to get to my day job ;)
Not sure if you like that I added some KeyCode definitions that are not defined here:
http://www.javascripter.net/faq/keyeventconstantsfirefox.htm
Those listed below are not defined in the , as IE deviates from other browsers. Since brackets uses them I added them following the same naming convention as other key codes. We may want to use a different prefix rather than DOM_VK? to stay consisten Happy to change if you prefer.
DOM_VK_SEMICOLON: 186,
DOM_VK_EQUALS: 187,
DOM_VK_COMMA: 188,
DOM_VK_DASH: 189
Adding them in required to remove definition defined the reference doc above:
DOM_VK_EQUALS: 61,
DOM_VK_SEMICOLON: 59,
I have not updated any key code references in sources in 3rd party or extensions.
Jochen
couzteau included the following code: https://github.com/adobe/brackets/pull/1583/commits