Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Update "de" locale #1537

Open
core-ai-bot opened this issue Aug 29, 2021 · 5 comments
Open

[CLOSED] Update "de" locale #1537

core-ai-bot opened this issue Aug 29, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by ZweiSteinSoft
Thursday Sep 06, 2012 at 11:26 GMT
Originally opened as adobe/brackets#1572



ZweiSteinSoft included the following code: https://github.com/adobe/brackets/pull/1572/commits

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Sep 07, 2012 at 20:31 GMT


We should try to merge this in by 9/10 for UI freeze.

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Sunday Sep 09, 2012 at 18:15 GMT


Done reviewing first pass. Very nice job! I suggested a few more changes since Friday. Please have a look :) We're approaching UI freeze for Sprint 14, would be great if you could merge in what makes sense to you soon.

Thanks a ton for you contributions, I'm sure folks in Germany will appreciate your efforts - be assured we do very much!

@core-ai-bot
Copy link
Member Author

Comment by ZweiSteinSoft
Monday Sep 10, 2012 at 10:14 GMT


Please see my comments in the “outdated diff” collapsed links.

@core-ai-bot
Copy link
Member Author

Comment by ZweiSteinSoft
Monday Sep 10, 2012 at 16:16 GMT


@pthiess: Please review my further changes as in 52f3910 and 5319759.

@core-ai-bot
Copy link
Member Author

Comment by pthiess
Monday Sep 10, 2012 at 16:23 GMT


Looks good - still one exception - please take a look at my commet about the translation of humble. You may change this as a bug fix later.

Merging.. Again Great work, very happy to see it getting in...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant