[CLOSED] Live development

[core-ai-bot]

Issue by jdiehl
Friday Jul 20, 2012 at 09:01 GMT
Originally opened as adobe/brackets#1286

---

Updated to latest brackets/master
Enabled all live-development features

This pull request includes language switching

---

jdiehl included the following code: https://github.com/adobe/brackets/pull/1286/commits

[core-ai-bot]

Comment by joelrbrandt
Saturday Jul 21, 2012 at 01:30 GMT

---

Thanks for submitting this! I'll work with the team to get this reviewed during the next Sprint (starting Tues, July 24)

[core-ai-bot]

Comment by jdiehl
Tuesday Jul 24, 2012 at 20:10 GMT

---

This pull request now includes sprint 11

[core-ai-bot]

Comment by joelrbrandt
Thursday Jul 26, 2012 at 18:51 GMT

---

@jdiehl I reviewed this and it looks good to merge. Thanks for updating this.

However, the language switching / localization stuff (from #1285) is in this pull request as well. Can you remove that from this pull request?

btw, thanks for providing the German translation! The plan for Monday's architecture meeting is to discuss how we'll do language switching, taking into account your proposal. But, if we go a slightly different path with how we do the loading, it will be confusing to have a different version of language switching in this branch.

Thanks!

[core-ai-bot]

Comment by jdiehl
Thursday Jul 26, 2012 at 20:26 GMT

---

Removed the localization stuff

[core-ai-bot]

Comment by joelrbrandt
Thursday Jul 26, 2012 at 21:05 GMT

---

Looks great, merging! Thanks for doing this.

(Actually, there's a JSLint error at line 140 in LiveDevelopment.js, but I'll fix that since we're not working in master anyway.)

[core-ai-bot]

Comment by jdiehl
Thursday Jul 26, 2012 at 21:12 GMT

---

remove the "throw" statement

• jonathan

On 26.07.2012, at 23:05, Joel Brandt reply@reply.github.com wrote:

Looks great, merging! Thanks for doing this.

(Actually, there's a JSLint error at line 140 in LiveDevelopment.js, but I'll fix that since we're not working in master anyway.)

---

Reply to this email directly or view it on GitHub:
adobe/brackets#1286 (comment)