Cleaner approach to HeaderMixin
#285
Draft
+41
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a new TemplateResponse which will let us more cleanly inject headers into the response.
Codecov Report
@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 97.72% 97.77% +0.05%
==========================================
Files 8 8
Lines 484 495 +11
Branches 68 69 +1
==========================================
+ Hits 473 484 +11
Misses 9 9
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a backwards-compatible change to the
HeaderMixin. Our existing method works but feels kind of heavy-handed. This approach is more in-line with Django's design, IMO, and doesn't feel as blunt.Unfortunately, it only works if
render_to_responseis ultimately called, so I had to leave in the old approach as well. Maybe we should split it up into a new mixin?