Skip to content

Commit f40f22e

Browse files
author
Niklas Kiefer
committed
test(a11y): remove scrollable rule for palette
This is resolved now 🎉
1 parent 8690082 commit f40f22e

File tree

3 files changed

+1
-21
lines changed

3 files changed

+1
-21
lines changed

e2e/visual/no-theme.spec.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,8 @@ test('no-theme - editor', async ({ page, makeAxeBuilder }) => {
7777
await expect(page).toHaveScreenshot();
7878

7979
// and then
80-
// @Note(pinussilvestrus): the palette entries are currently
81-
// not keyboard accessible, as we need to invest in an overall
82-
// editor keyboard experience
83-
// cf. https://github.com/bpmn-io/form-js/issues/536
8480
const results = await makeAxeBuilder({
8581
disableRules: [
86-
'scrollable-region-focusable',
8782
'page-has-heading-one'
8883
]
8984
}).analyze();

e2e/visual/theming.spec.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,8 @@ test('theming - editor', async ({ page, makeAxeBuilder }) => {
7777
await expect(page).toHaveScreenshot();
7878

7979
// and then
80-
// @Note(pinussilvestrus): the palette entries are currently
81-
// not keyboard accessible, as we need to invest in an overall
82-
// editor keyboard experience
83-
// cf. https://github.com/bpmn-io/form-js/issues/536
8480
const results = await makeAxeBuilder({
8581
disableRules: [
86-
'scrollable-region-focusable',
8782
'page-has-heading-one'
8883
]
8984
}).analyze();

packages/form-js-editor/test/spec/FormEditor.spec.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1501,17 +1501,7 @@ describe('FormEditor', function() {
15011501
});
15021502

15031503
// then
1504-
// @Note(pinussilvestrus): the palette entries are currently
1505-
// not keyboard accessible, as we need to invest in an overall
1506-
// editor keyboard experience
1507-
// cf. https://github.com/bpmn-io/form-js/issues/536
1508-
await expectNoViolations(container, {
1509-
rules: {
1510-
'scrollable-region-focusable': {
1511-
enabled: false
1512-
}
1513-
}
1514-
});
1504+
await expectNoViolations(container);
15151505
});
15161506

15171507
});

0 commit comments

Comments
 (0)