Add support for better ssh repo handling

Author: wfarr

lib/puppet/provider/repository/git.rb

@@ -13,6 +13,13 @@ def self.default_protocol
     'https'
   end
 
+  def self.validate(v)
+    unless %w(git ssh https).member? v.to_s
+      raise Puppet::Error, \
+        "Protocol can only be git, https, or ssh for now!"
+    end
+  end
+
   def query
     h = { :name => @resource[:name], :provider => :git }
 
@@ -70,7 +77,14 @@ def destroy
 
   def expand_source(source)
     if source =~ /\A[^@\/\s]+\/[^\/\s]+\z/
-      "#{@resource[:protocol]}://github.com/#{source}"
+      case @resource[:protocol]
+      when "git", "https"
+        "#{@resource[:protocol]}://github.com/#{source}"
+      when "ssh"
+        "git@github.com:#{source}.git"
+      else
+        raise "failtown"
+      end
     else
       source
     end

lib/puppet/type/repository.rb

@@ -60,13 +60,17 @@ def insync?(is)
         provider.class.default_protocol
       end
     end
+
+    validate do |v|
+      provider.class.validate v
+    end
   end
 
   newparam :user do
     desc "User to run this operation as."
 
     defaultto do
-      Facter[:boxen_user].value
+      Facter.value(:boxen_user) || Facter.value(:id) || "root"
     end
   end
 

spec/unit/puppet/type/repository_spec.rb

@@ -4,7 +4,7 @@
   let(:default_opts) do
     {
       :source => 'boxen/boxen',
-      :path => '/tmp/boxen'
+      :path => '/tmp/boxen',
     }
   end
 
@@ -82,15 +82,16 @@
     end
 
     it "should default to boxen_user if it exists" do
-      Facter[:boxen_user].stubs(:value).returns(nil)
-      factory.call(default_opts)[:user].should == nil
+      Facter.stubs(:value).with(:boxen_user).returns(nil)
+      Facter.stubs(:value).with(:id).returns(nil)
+      factory.call(default_opts)[:user].should == "root"
 
-      Facter[:boxen_user].stubs(:value).returns('testuser')
+      Facter.stubs(:value).with(:boxen_user).returns('testuser')
       factory.call(default_opts)[:user].should == 'testuser'
     end
 
     it "should override boxen_user if both exist" do
-      Facter[:boxen_user].stubs(:value).returns('testuser')
+      Facter.stubs(:value).with(:boxen_user).returns('testuser')
 
       opts = default_opts.merge(:user => "otheruser")
       factory.call(opts)[:user].should == 'otheruser'