Exit Job early when the Pollable Task is already finished #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pollable tasks are marked as finished before the Quartz job actually terminates. There is no global transaction that binds the finishing of the PollableTask with the Quartz job. As such it is possible that a Pollable Task is marked as finished but the Quartz job is not and I’m suspecting that if the scheduler goes down after the pollable task being marked as finished and before the Quartz job is marked as finished then the Quartz job might be retriggered. That would lead to running again a finished PollableTask. This exit early when the Pollable Task is already finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pollable tasks are marked as finished before the Quartz job actually terminates. There is no global transaction that binds the finishing of the PollableTask with the Quartz job. As such it is possible that a Pollable Task is marked as finished but the Quartz job is not and I’m suspecting that if the scheduler goes down after the pollable task being marked as finished and before the Quartz job is marked as finished then the Quartz job might be retriggered. That would lead to running again a finished PollableTask.
This exit early when the Pollable Task is already finished