Skip to content

Commit 2e72387

Browse files
ShahanaFarooquirustyrussell
authored andcommitted
lightningd: removing bionic and python 3.7 support
Changelog-Removed: support for python v<=3.7 & Ubuntu bionic has been removed. clnrest's flask & gevent libraries require Python v>=3.8.
1 parent e5d0d69 commit 2e72387

File tree

3 files changed

+8
-82
lines changed

3 files changed

+8
-82
lines changed

contrib/reprobuild/Dockerfile.bionic

Lines changed: 0 additions & 69 deletions
This file was deleted.

doc/getting-started/advanced-setup/repro.md

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ the non-updated repos).
3838

3939
The following table lists the codenames of distributions that we currently support:
4040

41-
- Ubuntu 18.06:
42-
- Distribution Version: 18.04
43-
- Codename: bionic
4441
- Ubuntu 20.04:
4542
- Distribution Version: 20.04
4643
- Codename: focal
@@ -51,7 +48,7 @@ The following table lists the codenames of distributions that we currently suppo
5148
Depending on your host OS release you might not have `debootstrap` manifests for versions newer than your host OS. Due to this we run the `debootstrap` commands in a container of the latest version itself:
5249

5350
```shell
54-
for v in bionic focal jammy; do
51+
for v in focal jammy; do
5552
echo "Building base image for $v"
5653
sudo docker run --rm -v $(pwd):/build ubuntu:22.04 \
5754
bash -c "apt-get update && apt-get install -y debootstrap && debootstrap $v /build/$v"
@@ -62,16 +59,16 @@ done
6259
Verify that the image corresponds to our expectation and is runnable:
6360

6461
```shell
65-
sudo docker run bionic cat /etc/lsb-release
62+
sudo docker run jammy cat /etc/lsb-release
6663
```
6764

68-
Which should result in the following output for `bionic`:
65+
Which should result in the following output for `jammy`:
6966

7067
```shell
7168
DISTRIB_ID=Ubuntu
72-
DISTRIB_RELEASE=18.04
73-
DISTRIB_CODENAME=bionic
74-
DISTRIB_DESCRIPTION="Ubuntu 18.04 LTS"
69+
DISTRIB_RELEASE=22.04
70+
DISTRIB_CODENAME=jammy
71+
DISTRIB_DESCRIPTION="Ubuntu 22.04 LTS"
7572
```
7673

7774
## Builder image setup
@@ -83,7 +80,6 @@ For this purpose we have a number of Dockerfiles in the [`contrib/reprobuild`](h
8380
We can then build the builder image by calling `docker build` and passing it the `Dockerfile`:
8481

8582
```shell
86-
sudo docker build -t cl-repro-bionic - < contrib/reprobuild/Dockerfile.bionic
8783
sudo docker build -t cl-repro-focal - < contrib/reprobuild/Dockerfile.focal
8884
sudo docker build -t cl-repro-jammy - < contrib/reprobuild/Dockerfile.jammy
8985
```
@@ -99,7 +95,6 @@ Finally, after this rather lengthy setup we can perform the actual build. At th
9995
We'll need the release directory available for this, so create it now if it doesn't exist:`mkdir release`, then we can simply execute the following command inside the git repository (remember to checkout the tag you are trying to build):
10096

10197
```bash
102-
sudo docker run --rm -v $(pwd):/repo -ti cl-repro-bionic
10398
sudo docker run --rm -v $(pwd):/repo -ti cl-repro-focal
10499
sudo docker run --rm -v $(pwd):/repo -ti cl-repro-jammy
105100
```

tools/build-release.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ for target in $TARGETS; do
150150
echo "Fedora Image Built"
151151
;;
152152
Ubuntu)
153-
for d in bionic focal jammy; do
153+
for d in focal jammy; do
154154
# Capitalize the first letter of distro
155155
D=$(echo "$d" | awk '{print toupper(substr($0,1,1))substr($0,2)}')
156156
echo "Building Ubuntu $D Image"
@@ -197,7 +197,7 @@ if [ -z "${TARGETS##* deb *}" ]; then
197197
BLDDIR="${TMPDIR}/clightning-${VERSION}"
198198
ARCH="$(dpkg-architecture -q DEB_BUILD_ARCH)"
199199

200-
for SUITE in bionic focal hirsute xenial hirsute impish; do
200+
for SUITE in focal hirsute xenial hirsute impish; do
201201

202202
mkdir -p "${BLDDIR}"
203203
echo "Building ${BARE_VERSION} in ${TMPDIR}"

0 commit comments

Comments
 (0)