Skip to content

Commit 92bc3bb

Browse files
committed
buildsys: refactor builder.rs
Refactor the code, primarily in builder.rs. The goal of the refactor is to segregate data collection and docker argument creation from program flow logic.
1 parent 52cf9ba commit 92bc3bb

File tree

4 files changed

+382
-287
lines changed

4 files changed

+382
-287
lines changed

tools/buildsys/src/args.rs

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ of its input arguments from environment variables.
55
66
!*/
77

8+
use buildsys::manifest::SupportedArch;
89
use clap::{Parser, Subcommand};
910
use std::path::PathBuf;
1011
use url::Url;
@@ -55,10 +56,10 @@ impl Command {
5556
#[derive(Debug, Parser)]
5657
pub(crate) struct Common {
5758
#[arg(long, env = "BUILDSYS_ARCH")]
58-
pub(crate) arch: String,
59+
pub(crate) arch: SupportedArch,
5960

6061
#[arg(long, env = "BUILDSYS_OUTPUT_DIR")]
61-
pub(crate) output_dir: PathBuf,
62+
pub(crate) image_arch_variant_dir: PathBuf,
6263

6364
#[arg(long, env = "BUILDSYS_ROOT_DIR")]
6465
pub(crate) root_dir: PathBuf,
@@ -80,6 +81,9 @@ pub(crate) struct Common {
8081

8182
#[arg(long, env = "TLPRIVATE_TOOLCHAIN")]
8283
pub(crate) toolchain: String,
84+
85+
#[arg(long, env = "TWOLITER_TOOLS_DIR")]
86+
pub(crate) tools_dir: PathBuf,
8387
}
8488

8589
/// Build RPMs from a spec file and sources.
@@ -91,6 +95,21 @@ pub(crate) struct BuildPackageArgs {
9195
#[arg(long, env = "BUILDSYS_VARIANT")]
9296
pub(crate) variant: String,
9397

98+
#[arg(long, env = "BUILDSYS_VARIANT_PLATFORM")]
99+
pub(crate) variant_platform: String,
100+
101+
#[arg(long, env = "BUILDSYS_VARIANT_RUNTIME")]
102+
pub(crate) variant_runtime: String,
103+
104+
#[arg(long, env = "BUILDSYS_VARIANT_FAMILY")]
105+
pub(crate) variant_family: String,
106+
107+
#[arg(long, env = "BUILDSYS_VARIANT_FLAVOR")]
108+
pub(crate) variant_flavor: String,
109+
110+
#[arg(long, env = "PUBLISH_REPO")]
111+
pub(crate) publish_repo: String,
112+
94113
#[arg(long, env = "BUILDSYS_SOURCES_DIR")]
95114
pub(crate) sources_dir: PathBuf,
96115

0 commit comments

Comments
 (0)