Skip to content

Make FileUpload.save accept Path instance for destination #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
johndoe46 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make FileUpload.save accept Path instance for destination #1482

johndoe46 wants to merge 1 commit into from

Conversation

@johndoe46
Copy link

@johndoe46 johndoe46 commented Mar 22, 2025

Path instance is detected and converted to str. No other changes.

@johndoe46
Make FileUpload.save accept Path instance for destination
00ecfd5 
Path instance is detected and converted to str.
@defnull
Copy link
Member

defnull commented Apr 21, 2025

I would prefer to actually move from os.path to pathlib.Path whenever possible, ans support both str and os.PathLike as input to those functions/methods.

@defnull defnull added the Feature This is a feature request, not a bug. Open for discussion. label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Feature This is a feature request, not a bug. Open for discussion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johndoe46 @defnull