Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v0.13-dev) Can't run aiohttp server #995

Closed
Michael-F-Ellis opened this issue Sep 7, 2017 · 5 comments
Closed

(v0.13-dev) Can't run aiohttp server #995

Michael-F-Ellis opened this issue Sep 7, 2017 · 5 comments
Milestone

Comments

@Michael-F-Ellis
Copy link

Traceback (most recent call last):
  File "/Users/mellis/ls-mapped-mode/bottle.py", line 3709, in run
    server.run(app)
  File "/Users/mellis/ls-mapped-mode/bottle.py", line 3511, in run
    from aiohttp.wsgi import WSGIServerHttpProtocol
ImportError: No module named 'aiohttp.wsgi'
Bottle v0.13-dev server starting up (using AiohttpServer())...

Apparently aiohttp has obsoleted .wsgi. See aio-libs/aiohttp#1108

Truth be told, my real interest here is to be able to run some background tasks as coroutines without having to resort to subprocesses or threads. I read your writeup about using gevent but prefer to use asyncio and async/await since these are now built into Python. Any suggestions?

Thanks!

@hartwork
Copy link
Contributor

hartwork commented Jan 1, 2019

For the record you need pip install aiohttp<2 to make that work.

Related commit:
aio-libs/aiohttp@9218c26

@hartwork
Copy link
Contributor

hartwork commented Jan 2, 2019

Related: #1118

@defnull
Copy link
Member

defnull commented Jul 10, 2019

Removing a non-working adapter (e.g. rocket) is fine. Removing a somewhat-working adapter that might be used by some users may be problematic without a deprecation round. On the other hand, it is very easy to just copy&paste the <10 lines from the old bottle release to your own application to re-introduce a removed adapter. If upstream dropped support already, it should be fine if we do so, too, without a deprecation-round.

@defnull defnull added this to the Release 0.13 milestone Jul 10, 2019
@hartwork
Copy link
Contributor

hartwork commented Dec 18, 2019

For v0.13-dev on master backend aiohttp uses aiohttp-wsgi as a bridge now and supports aiohttp>=2 (see 3d9a8c1). I believe this bug is fixed and can be closed.

@defnull defnull closed this as completed Dec 18, 2019
@hartwork
Copy link
Contributor

Was that^^ comment was meant to go into #1119?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants