Updated tests and winscroll.bas #1010
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monday, 13th October: In https://t.me/c/2140206582/3299 by @thearduinoguy the effect of WinScrollLeft is seen on a game screen he is programming.
Tuesday, 14th October: I replied "The WinScroll* SUBs first scroll the Display File (black & white, pixels), then the Attributes. Therefore, you can see a magenta diamond on black paper that sometimes is seen as black diamond on yellow paper. To avoid this effect, the WinScrollLeft SUB should scroll "pixels" and attributes "at the same time" (on a character by character basis) or "almost the same time" (on a line-of-characters by line-o-c basis).
The same mismatch between "pixels" and attributes could happen (maybe, maybe not) with the doublebuffer technique if the memcopy first copies the Display File then the Attributes.
By copying Display File and Attributes on a char-by-char basis, such mismatchs in colour do not happen,"
He replied "Sounds like the WinScroll routine needs rewriting"
And Boriel added "Yes, that could be nice to have (perhaps the routine will take a few more bytes, but IMHO It's worh it).
If anyone wants to issue a PR for this, I'll review it and integrate it."
Sunday, 19th October: So, here it is!