Use KeyVector for proper wrapping with TBB #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunagrawal
added
bugfix
akshay-krishnan
approved these changes
Nov 16, 2020
|
Woosh, you tracked that down quickly. I was still swimming around in the Boost docs for sp_forward thinking it was something to do with the arguments we were forwarding via Boost. Nice work! I can confirm that this does fix the problem on my machine. Maybe this fixes some of the other issues sprinkled around that have to do with the wrapper and TBB? |
|
@tmcg0 maybe? I'm going to have to touch base with all the other issue reporters to see if this solves their problem. |
This was referenced Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #598. All I had to do was replace
vector<Key>withKeyVectorsince the latter supports allocator overloading (which is needed for TBB).@tmcg0