Fix examples that were using filter
#1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchenfc
approved these changes
Jan 21, 2023
There was a problem hiding this comment.
This might have been obvious to others, but I just realized that the reason #1398 (and #1397) passed CI check (special cases CI - deprecated) is because CI is never compiling examples. Even though the ci scripts have a flag to compile examples (-b ):
Lines 134 to 141 in 6787bbe
Lines 91 to 94 in 6787bbe
Lines 112 to 115 in 6787bbe
all the CI's are actually only using -t:
gtsam/.github/workflows/build-special.yml
Lines 141 to 143 in 6787bbe
Perhaps we should consider compiling the examples as well in CI, at least in e.g. release branches.
|
Agreed ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from c71d07b
Fixes issue #1400