Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid/simplify #1388

Merged
merged 29 commits into from
Jan 17, 2023
Merged

Hybrid/simplify #1388

merged 29 commits into from
Jan 17, 2023

Commits on Jan 16, 2023

  1. normalizationConstants returns all constants as a DecisionTreeFactor

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    34a9aef View commit details
    Browse the repository at this point in the history

  2. All tests still work with zero constant!

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    1dcc6dd View commit details
    Browse the repository at this point in the history

  3. Removed FactorAndConstant, no longer needed

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    03ad393 View commit details
    Browse the repository at this point in the history

  4. Add discrete contribution to logProbability

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    906330f View commit details
    Browse the repository at this point in the history

  5. Expose toFactorGraph to wrapper

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    681c75c View commit details
    Browse the repository at this point in the history

  6. Simplify elimination

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    dfef2c2 View commit details
    Browse the repository at this point in the history

  7. insert_or_assign

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    070cdb7 View commit details
    Browse the repository at this point in the history

  8. Some test refactoring

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    96e3eb7 View commit details
    Browse the repository at this point in the history

  9. Improved docs

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    c22b2ca View commit details
    Browse the repository at this point in the history

  10. Check for error>0 and proper normalization constant

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    5b0408c View commit details
    Browse the repository at this point in the history

  11. Fix print

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    191e614 View commit details
    Browse the repository at this point in the history

  12. Compute log-normalization constant as the max of the individual norma… 

    …lization constants.
    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    57e59d1 View commit details
    Browse the repository at this point in the history

  13. Refactored tests and removed incorrect (R not upper-triangular) test.

    @dellaert
    dellaert committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    7a41180 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Implemented the "hidden constant" scheme.

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    207c9b7 View commit details
    Browse the repository at this point in the history

  2. Explicitly implement logNormalizationConstant

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    3a446d7 View commit details
    Browse the repository at this point in the history

  3. Fixed toFactorGraph and added test to verify

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    202a5a3 View commit details
    Browse the repository at this point in the history

  4. Fixed test to work with "hidden constant" scheme

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    a5951d8 View commit details
    Browse the repository at this point in the history

  5. Fix python tests (and expose HybridBayesNet.error)

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    8357fc7 View commit details
    Browse the repository at this point in the history

  6. Eradicated GraphAndConstant

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    e31884c View commit details
    Browse the repository at this point in the history

  7. Added DEBUG_MARGINALS flag

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    9af7236 View commit details
    Browse the repository at this point in the history

  8. Added comment

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    519b2bb View commit details
    Browse the repository at this point in the history

  9. Trap if conditional==null.

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    32d69a3 View commit details
    Browse the repository at this point in the history

  10. Fix logProbability tests

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    f4859f0 View commit details
    Browse the repository at this point in the history

  11. Ratio test succeeds on fg, but not on posterior yet,

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    4283925 View commit details
    Browse the repository at this point in the history

  12. Removed obsolete normalizationConstants method

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    b494a61 View commit details
    Browse the repository at this point in the history

  13. Add math related to hybrid classes

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    892759e View commit details
    Browse the repository at this point in the history

  14. Added partial elimination test

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    c3ca31f View commit details
    Browse the repository at this point in the history

  15. Added correction with the normalization constant in the second elimin… 

    …ation path.
    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    e444962 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'develop' into hybrid/simplify

    @dellaert
    dellaert committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    f714c4a View commit details
    Browse the repository at this point in the history