Test on ratio #1357
Merged
Test on ratio #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** For all key/value pairs in \c values, replace values with corresponding keys in this class | ||
| * with those in \c values. Throws std::out_of_range if any keys in \c values are not present | ||
| * in this class. */ | ||
| void update(const VectorValues& values) { continuous_.update(values); } |
There was a problem hiding this comment.
There's a TODO from @xsj01 that we should probably kill.
|
Since all of these are small comments and this is an ongoing process, let's resolve all comments in follow up PRs. Still think all this noise is better in a fork. |
varunagrawal
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@varunagrawal this shows the ratio is broken from the very start :-/
I propose you merge this one and previous one, and then do a PR with your improvements (after merging in develop then) (not the one with HessianMatrix changes). Then I'll review so I know what's up and suggest a course of action.
Timing-wise: I have time to look at your PR at around 10:30pm ATL time.