Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrapper warnings #1348

Merged
merged 2 commits into from
Dec 25, 2022
Merged

Fix wrapper warnings #1348

merged 2 commits into from
Dec 25, 2022

Conversation

varunagrawal
Copy link
Collaborator

Fix some warnings from gtsam_unstable.i due to the update to NoiseModelFactorN.

@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label Dec 24, 2022
@varunagrawal varunagrawal self-assigned this Dec 24, 2022
@varunagrawal
Copy link
Collaborator Author

Fixed some additional deprecation warnings as well which are internal to factor implementations, so it shouldn't affect the external API.

gchenfc
gchenfc approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@gchenfc gchenfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My bad missing these, I think I had turned off unstable for wrappers

Clever use of template in gtsam_unstable.i : IMUFactor 😂

@varunagrawal
Copy link
Collaborator Author

Hey man, I'm not a GTSAM wrapper expert without reason. 😎

@varunagrawal
Copy link
Collaborator Author

varunagrawal commented Dec 24, 2022 •
edited
Loading

Also no worries. This is why we have labmates to support one another. :)

@varunagrawal varunagrawal merged commit d7491a1 into develop Dec 25, 2022
@varunagrawal varunagrawal deleted the fix/wrapper branch December 25, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchenfc gchenfc gchenfc approved these changes

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunagrawal @dellaert @gchenfc