Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping Updates #1321

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Housekeeping Updates #1321

merged 2 commits into from
Nov 14, 2022

Conversation

varunagrawal
Copy link
Collaborator

Some updates while I was working with @raabuchanan to finish up the Buchanan22ral paper.

  1. Allow scripts in examples directory to link to gtsam_unstable. This helps prevent weird build errors.
  2. Set macro for better Pybind error messages.

@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label Nov 7, 2022
@varunagrawal varunagrawal self-assigned this Nov 7, 2022
@varunagrawal varunagrawal merged commit 0d60d80 into develop Nov 14, 2022
@varunagrawal varunagrawal deleted the housekeeping branch November 14, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

@dellaert dellaert Awaiting requested review from dellaert

Assignees

@varunagrawal varunagrawal

Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunagrawal @ProfFan @laxnpander