Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geometry.i : wrap multiplication of Rot3 and Unit3 #1302

Merged
merged 5 commits into from
Dec 25, 2022

Conversation

akshay-krishnan
Copy link
Contributor

No description provided.

@varunagrawal
Copy link
Collaborator

@akshay-krishnan please add some unit tests and I will happily approve this. :)

@varunagrawal
Copy link
Collaborator

@akshay-krishnan any updates on this? We're looking to release a new version, and if you can finish up the unit tests, let's land this so it can be included in the 4.2 release.

@akshay-krishnan
Copy link
Contributor Author

Thanks for the reminder Varun, I'll update it today

@akshay-krishnan
Copy link
Contributor Author

@varunagrawal I could not wrap the * operator, got the error "no supported * operator between Rot3 and Unit3", although I added the method in geometry.i (see my first commit).

So I had to remove that, rotate() and unrotate() are fine, and apparently * operator is not wrapped for Point3 either.

Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal
Copy link
Collaborator

@varunagrawal I could not wrap the * operator, got the error "no supported * operator between Rot3 and Unit3", although I added the method in geometry.i (see my first commit).

So I had to remove that, rotate() and unrotate() are fine, and apparently * operator is not wrapped for Point3 either.

Huh that's strange. I can take a look at it later maybe? Super swamped.

@varunagrawal varunagrawal merged commit af6a4f2 into develop Dec 25, 2022
@varunagrawal varunagrawal deleted the wrap-unit3-rot branch December 25, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants