Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid Improvements #1290

Merged
merged 6 commits into from
Oct 4, 2022
Merged

Hybrid Improvements #1290

merged 6 commits into from
Oct 4, 2022

Conversation

varunagrawal
Copy link
Collaborator

  1. HybridNonlinearFactorGraph::linearize returns a shared pointer instead of an object so we avoid a copy.
  2. Added overloaded HybridNonlinearFactorGraph::push_back for containers. Needed else compiler has ambiguity errors.
  3. Added new HybridNonlinearISAM class based on the NonlinearISAM class. Works well as per the unit tests.

@varunagrawal varunagrawal self-assigned this Sep 13, 2022
@ProfFan
Copy link
Collaborator

ProfFan commented Sep 14, 2022

CI fails

@varunagrawal
Copy link
Collaborator Author

Gentle reminder for review.

@varunagrawal varunagrawal merged commit 903d7c6 into develop Oct 4, 2022
@varunagrawal varunagrawal deleted the hybrid/improvements branch October 4, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

@keevindoherty keevindoherty Awaiting requested review from keevindoherty

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @ProfFan