Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Fixes #1288

Merged
merged 7 commits into from
Sep 13, 2022
Merged

Various Fixes #1288

merged 7 commits into from
Sep 13, 2022

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Sep 2, 2022 •
edited
Loading

Made various fixes and improvements as I was fixing a bug in Hybrid Estimation.

  1. Better naming in HybridJunctionTree.
  2. Changed myJTNode to junctionTreeNode in ConstructorTraversalData. I am hoping to subclass HybridConstructorTraversalData.
  3. Remove unused variables in tests.
  4. Remove nrContinuous from HybridFactor since we can compute that from continuousKeys.

@varunagrawal varunagrawal self-assigned this Sep 2, 2022
Base automatically changed from hybrid/multifrontal-fix to develop September 13, 2022 16:15
@varunagrawal varunagrawal merged commit 3e25e7d into develop Sep 13, 2022
@varunagrawal varunagrawal deleted the misc/fixes branch September 13, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @ProfFan