Hybrid Incremental #1271
Merged
Hybrid Incremental #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfFan
reviewed
Aug 19, 2022
| // } | ||
| // Test for figuring out the optimal ordering to ensure we get | ||
| // a discrete graph after elimination. | ||
| TEST(HybridGaussianISAM, NonTrivial) { |
There was a problem hiding this comment.
Is this one meant to be commented out?
There was a problem hiding this comment.
Yeah I am working on getting this to pass. I might need to open a separate PR though since it has some non-trivial changes.
ProfFan
approved these changes
Aug 19, 2022
|
Tagging @keevindoherty to keep him in the loop. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for running HybridGaussianISAM as well as lots of fixes and improvements to the pruning methodology.
I also added an optional ordering parameter to the
HybridGaussianISAM::updatemethod so we can pass in custom orderings as needed.