Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templated type declaration in geometry.i #1205

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

varunagrawal
Copy link
Collaborator

For using templated types in methods in the wrapper, we need to use This instead of Class<T>.

This may be a strong requirement, but it is convenient and unless there is a strong argument for changing this default behavior, I'm going to keep it as is.

Fixes #1184

@varunagrawal varunagrawal added the matlab Related to MATLAB wrapper label May 25, 2022
@varunagrawal varunagrawal self-assigned this May 25, 2022
@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label May 25, 2022
@varunagrawal varunagrawal merged commit 12aed1f into develop Jun 2, 2022
@varunagrawal varunagrawal deleted the fix/matlab-geometry branch June 2, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
matlab Related to MATLAB wrapper quick-review Quick and easy PR to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in building MATLAB wrapper: TypeError: unhashable type: 'Typename'
2 participants