Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix robust deserialization #1169

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Fix robust deserialization #1169

merged 1 commit into from
Apr 15, 2022

Conversation

ProfFan
Copy link
Collaborator

@ProfFan ProfFan commented Apr 14, 2022

Closes #1164

varunagrawal
varunagrawal approved these changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal
Copy link
Collaborator

Though I'm wondering why don't we have a unit test for this. We have tools for testing serialization.

@ProfFan
Copy link
Collaborator Author

ProfFan commented Apr 15, 2022

Yeah I think we just didn't (or can't) test all combinations of these models...

@ProfFan ProfFan merged commit 5955ecc into develop Apr 15, 2022
@ProfFan ProfFan deleted the fix/robust_deserialization branch April 15, 2022 18:03
@varunagrawal
Copy link
Collaborator

We can. It just needs some time and effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

@dellaert dellaert Awaiting requested review from dellaert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with deserialize GenericProjectionFactor with python and Cauchy
2 participants
@ProfFan @varunagrawal