Wrapping Updates #1146
Merged
Wrapping Updates #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfFan
approved these changes
Mar 25, 2022
| @@ -175,6 +175,7 @@ struct ISAM2Result { | |||
| /** Getters and Setters */ | |||
| size_t getVariablesRelinearized() const { return variablesRelinearized; } | |||
| size_t getVariablesReeliminated() const { return variablesReeliminated; } | |||
| FactorIndices getNewFactorsIndices() const { return newFactorsIndices; } | |||
There was a problem hiding this comment.
Will MATLAB work with this?
There was a problem hiding this comment.
It should because FactorIndices is also a wrapped class 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
measuredmethods. Fixes Some objects in Python have no attribute 'measured' #1142getNewFactorsIndices()toISAM2Resultand wrapped it. Fixes ISAM2Result.newFactorsIndices() missing in Python? #1133