Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python install in CI #1054

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Update python install in CI #1054

merged 1 commit into from
Jan 22, 2022

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Jan 22, 2022

The Python Packaging Authority has decided to deprecate direct builds via calling setup.py (aka python setup.py install) due to the need to enforce a standard for wheel builds. More details here.

This effect first showed up on MacOS with the following error:

python3 setup.py install --user --prefix=
PACKAGES:  ['gtsam', 'gtsam_unstable', 'gtsam.utils', 'gtsam.examples', 'gtsam_unstable.tests', 'gtsam_unstable.examples']
running install
/usr/local/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
/usr/local/lib/python3.9/site-packages/setuptools/command/easy_install.py:156: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.

We are now seeing the deprecation effects in Ubuntu as well, so yeah this is going to need a bit of refactoring of the CI. I imagine this will effect the entirety of GTSAM going forward, hence this PR.

Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@varunagrawal
Copy link
Collaborator Author

At this point I'm confident the CI will succeed so merge whenever we're ready!

@dellaert dellaert merged commit 0638727 into develop Jan 22, 2022
@dellaert dellaert deleted the fix/ci-python-install branch January 22, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants