Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More DecisionTree improvements #1005

Merged
merged 6 commits into from
Jan 4, 2022
Merged

More DecisionTree improvements #1005

merged 6 commits into from
Jan 4, 2022

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Jan 4, 2022

  • Added some depth-first methods: fold, visit, visitWith
  • Use template for functions rather than std::functions, which matches against lambdas and function pointers as well.

@dellaert
Straight-up depth-first fold method
1585033 
# Conflicts:
#	gtsam/discrete/tests/testDecisionTree.cpp
@dellaert
visit and visitWith
5de3dc4
@dellaert
Use template parameter for functions, enables auto
b453152 
# Conflicts:
#	gtsam/discrete/DecisionTree-inl.h
#	gtsam/discrete/DecisionTree.h
@dellaert dellaert self-assigned this Jan 4, 2022
ProfFan
ProfFan approved these changes Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving sans one comment.

gtsam/navigation/ImuBias.h Show resolved Hide resolved
varunagrawal
varunagrawal approved these changes Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gtsam/navigation/ImuBias.h Show resolved Hide resolved
@dellaert dellaert merged commit 14ec0ae into develop Jan 4, 2022
@dellaert dellaert deleted the feature/better_decision_tree branch January 4, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees

@dellaert dellaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dellaert @varunagrawal @ProfFan