fix(s3): better Key function

bored-engineer · bored-engineer · commit f40fa4341cb1 · 2025-02-04T00:24:21.000-08:00
diff --git a/s3/storage.go b/s3/storage.go
@@ -21,8 +21,7 @@ import (
 
 // Key generates the S3 key from the URL.
 var Key = func(u url.URL) string {
-	u.Scheme = ""
-	return u.String()
+	return strings.TrimPrefix(u.String(), "https://")
 }
 
 // Storage implements the ghtransport.Storage interface backed by AWS S3.

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,7 @@ import (`
`21`	`21`
`22`	`22`	`// Key generates the S3 key from the URL.`
`23`	`23`	`var Key = func(u url.URL) string {`
`24`		`- u.Scheme = ""`
`25`		`- return u.String()`
	`24`	`+ return strings.TrimPrefix(u.String(), "https://")`
`26`	`25`	`}`
`27`	`26`
`28`	`27`	`// Storage implements the ghtransport.Storage interface backed by AWS S3.`