Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for landscape mode in 2.10.0.324 #102

Closed
dreadful-brain opened this issue Oct 2, 2021 · 3 comments
Closed

Support for landscape mode in 2.10.0.324 #102

dreadful-brain opened this issue Oct 2, 2021 · 3 comments
Labels
enhancement New feature or request next This issue will be addressed in the next release

Comments

@dreadful-brain
Copy link

First thanks for making rmview work in 2.10.0.324. While working great in portrait, there is still an issue in landscape mode.
If you present a landscape file, and rotating rmview e.g. clock wise, rmview switches back to portrait mode as soon as you write something on rM.

@bordaigorl
Copy link
Owner

Yes that's part of the orientation-autodetection mechanism.
This should only happen if you set "orientation": "auto".
What happens is that at every new frame, the autodetection tries to locate the UI buttons to determine if it's in landscape or portrait and adjust rotation accordingly.
The "orientation": "auto_on_load" setting restricts the autodetection to only the first frame, "orientation": "portrait" and "orientation": "landscape" disable the autodetection mechanism.

Could consider adding a menu entry to enable/disable autodetection.

@thomasvs
Copy link

thomasvs commented Dec 3, 2021

I was surprised by this behavior as well. It seems like it would be better to "remember" if the user rotated the display clockwise until the next time they change it manually?

btw, autodetect seems to work reasonably well when the menu is opened, but not when it's closed, even though that little circle stays there and ought to be enough to guess orientation?

@bordaigorl bordaigorl added enhancement New feature or request next This issue will be addressed in the next release labels Dec 14, 2021
@bordaigorl
Copy link
Owner

This was fixed in 166d6fc
Now manually rotating disables auto-rotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next This issue will be addressed in the next release
Projects
None yet
Development

No branches or pull requests

3 participants