status: Prep work for https://github.com/bootc-dev/bootc/pull/1285 #1291
Conversation
For increased clarity, prep for further changes. Signed-off-by: Colin Walters <walters@verbum.org>
Prep for displaying more information, like pinned state. Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
I've quickly changed a local version of #1285 to use the changes in this PR, and it now looks much cleaner.
Although this still doesn't allow us to access data stored within the HostStatus objects, which would be needed for displaying the /usr overlay status (#1258).
Unless you're thinking that can also be moved to be stored under BootEntry? Or am I completely overthinking the implementation again (a common occurrence with my recent PRs here)?
There was a problem hiding this comment.
Although this still doesn't allow us to access data stored within the HostStatus objects, which would be needed for displaying the /usr overlay status (#1258).
Unless you're thinking that can also be moved to be stored under BootEntry? Or am I completely overthinking the implementation again (a common occurrence with my recent PRs here)?
As is today, a usroverlay state is transient by default. It'd only be hotfix ones that we need to maintain persistently, but I've been trying to really discourage use of the hotfix path.
But anyways yes, we could pass down the metadata ultimately from ostree_deployment_get_unlocked() here.
See #1285