Skip to content

Commit bcdac01

Browse files
committed
install: Drop code/test uses of --security-opt
We think this is unnecessary now; part of improving the ergonomics of `bootc install` in general, but especially with the `to-existing-root` path. Once this lands, at some point later then we can also remove it from all of the documentation. But the most safe thing is to leave it in the docs for a bit longer. Closes: #928 Signed-off-by: Colin Walters <walters@verbum.org>
1 parent a89fe65 commit bcdac01

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

ostree-ext/.github/workflows/bootc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
- name: Integration tests
6060
run: |
6161
set -xeuo pipefail
62-
sudo podman run --rm -ti --privileged -v ./usr/bin/bootc:/usr/bin/bootc --pid=host --security-opt label=disable \
62+
sudo podman run --rm -ti --privileged -v ./usr/bin/bootc:/usr/bin/bootc --pid=host \
6363
quay.io/centos-bootc/centos-bootc-dev:stream9 bootc install to-filesystem \
6464
--karg=foo=bar --disable-selinux --replace=alongside /target
6565

tests-integration/src/install.rs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,7 @@ use fn_error_context::context;
1111
use libtest_mimic::Trial;
1212
use xshell::{cmd, Shell};
1313

14-
pub(crate) const BASE_ARGS: &[&str] = &[
15-
"podman",
16-
"run",
17-
"--rm",
18-
"--privileged",
19-
"--pid=host",
20-
"--security-opt",
21-
"label=disable",
22-
];
14+
pub(crate) const BASE_ARGS: &[&str] = &["podman", "run", "--rm", "--privileged", "--pid=host"];
2315

2416
// Arbitrary
2517
const NON_DEFAULT_STATEROOT: &str = "foo";

0 commit comments

Comments
 (0)