Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement detection of nested container #384

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Implement detection of nested container #384

wants to merge 1 commit into from

Conversation

simmplecoder
Copy link
Contributor

Description

This PR implements Miral's idea on supporting nested containers like std::array<std::array<...>> in kernel_2d_adaptor interface.

References

Tasklist

  • Implement nested container type detection
  • Add tests for nested container type detection
  • Fill in the logic
  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@simmplecoder
Implement detection of nested container
e50a621 
Interface enhancement for
kernel_2d_adaptor to support nested
containers. Implemented by adding
a template parameter with default value
@simmplecoder simmplecoder added the status/work-in-progress Do NOT merge yet until this label has been removed! label Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloskot mloskot mloskot approved these changes

@lpranam lpranam lpranam approved these changes

Assignees
No one assigned
Labels
status/work-in-progress Do NOT merge yet until this label has been removed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simmplecoder @mloskot @lpranam