Feature #34 LotusCodeInputForm #38
Merged
+112
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
framer-motion을 사용한 dnd 컴포넌트
naarang
approved these changes
Nov 12, 2024
|
근데 살짝 뭐랄까 LotusCodeInputForm이 widget 보다는 feature 같은 느낌이 들기도 해요! |
|
저도 고민중인데... ㅠ 어떻게 할지 잘 모르겠네요 feature와 관련된 로직이 많이 생겼을 때 빼보는 것도 좋아보이고.. |
|
나중에 리팩토링할 수 있으면 해보는 걸로 해요~! 머지하면 좋을 것 같습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#34
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항
서비스에서 DnD가 필요한 동적 입력란이 실행 입력란 외에는 없어서, 현재는 추상화하지 않고 그대로 사용하고 있습니다.
추후 다양한 환경에서 필요해진다면 추상화가 필요할 것으로 보입니다.
이 점을 감안해서 봐 주세요 🫠